From 84e4e67a503eefd311f0585337cc4a14b2b029d0 Mon Sep 17 00:00:00 2001 From: xyz Date: Wed, 15 Dec 2021 21:40:56 -0800 Subject: `[ -n "$a" ]` and `[ "$a" ]` seems the same, I decided to use the latter --- home/xyz/.local/bin/curlncm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'home/xyz/.local/bin/curlncm') diff --git a/home/xyz/.local/bin/curlncm b/home/xyz/.local/bin/curlncm index 73a6e66f..25f39aa9 100755 --- a/home/xyz/.local/bin/curlncm +++ b/home/xyz/.local/bin/curlncm @@ -39,14 +39,14 @@ shift $((OPTIND-1)) download_dir="${1:-"$PWD"}" [ -d "$download_dir" ] || mkdir -p "$download_dir" -if [ -n "$ids" ]; then +if [ "$ids" ]; then # temporary solution, can improve by auto curl names data="$(echo "$ids" | tr ',' '\n' | awk '{printf("%s\t%s\n",$0,"songname")}')" else - if [ -n "$rid" ]; then + if [ "$rid" ]; then data="$(curl -s -G --data-urlencode id="$rid" -d limit="$dj_max" 'https://music.163.com/djradio' | grep 'songlist\|tt f-thide' | sed -e 's/.*songlist-\(.*\)" class.*/\1/g' -e 's/.*title="\(.*\)".*/\1/g' | paste -sd '\t\n' | sort | tr '/' '_')" # can only curl featured 50 songs for the artist, can improve - elif [ -n "$aid" ]; then + elif [ "$aid" ]; then data="$(curl -s -G --data-urlencode id="$aid" 'https://music.163.com/artist' | grep '\[{.*}\]' | sed -e 's/.*>\[{/\[{/' -e 's/}\]<.*/}\]/' | jq -r '.[]|[.id,.name]|@tsv' | sort | tr '/' '_')" fi # awk code not print separator at beginning and end steal from: -- cgit v1.2.3-70-g09d2