fix a possible memory leak if a list is empty for XmbTextPropertyToTextList

1 files changed, 3 insertions, 2 deletions

diff --git a/dwm.c b/dwm.c
index 515e4e4..f26a943 100644
--- a/dwm.c
+++ b/dwm.c
@@ -924,8 +924,9 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size)
 		return 0;
 	if (name.encoding == XA_STRING) {
 		strncpy(text, (char *)name.value, size - 1);
-	} else if (XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success && n > 0 && *list) {
-		strncpy(text, *list, size - 1);
+	} else if (XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success) {
+		if (n > 0 && *list)
+			strncpy(text, *list, size - 1);
 		XFreeStringList(list);
 	}
 	text[size - 1] = '\0';